The button onclick in html has stopped working

Issue

I was making a website that using prompt popup to login. When I click the button, it didn’t work. How to slove this problem?

Code here:


<style>
button {
  background-color: #04AA6D;
  color: white;
  padding: 14px 20px;
  margin: 8px 0;
  border: none;
  cursor: pointer;
  width: 100%;
}
</style>
<script>
function myFunction() {
  let person = prompt("Please enter your username:", "");
  if (person == null || person == "") {
    text = "User cancelled the prompt.";
  } else if (person == "hi" || person == "test" || person == "1234") {
    window.location.href = "youtube.com/c/呂殿下";
  } else {
    window.location.href = "youtube.com";
}
</script>
<button onclick="myFunction();">Click me</button>
</body></html>

Solution

Your function had a couple of errors:

  • single = in first else if
  • no closing } for the else block

In order to make the branching visible, I am logging out the location instead of setting window.location.href for this example.

var text;

function myFunction() {
  let person = prompt("Please enter your username:", "");
  if (person == null || person == "") {
    text = "User cancelled the prompt.";
  } else if (person == "hi" || person == "test" || person == "1234") {
    console.log("setting href to sites.google.com/");
    //window.location.href = "sites.google.com/";
  } else {
    console.log("setting href to google.com");
    //window.location.href = "google.com";
    }
}
button {
  background-color: #04AA6D;
  color: white;
  padding: 14px 20px;
  margin: 8px 0;
  border: none;
  cursor: pointer;
  width: 100%;
}
<button onclick="myFunction()">Click me</button>

Answered By – Taxel

This Answer collected from stackoverflow, is licensed under cc by-sa 2.5 , cc by-sa 3.0 and cc by-sa 4.0

Leave a Reply

(*) Required, Your email will not be published